-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
29 move tutorial to readthedocs #103
Conversation
@mhauru @myyong could one or other of you be able to review this PR for us? Preview here: https://sqlsynthgen--103.org.readthedocs.build/en/103/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I had some comments local to individual lines and paragraphs, but very happy with the overall structure, the example Airbnb case, and all that.
I made several changes suggested by @mhauru in the last commits. Please let me know if more edits are required :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Carlos, I had a couple more comments
@mhauru , your comments were addressed in the last commit :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, thanks Carlos!
Add an end-to-end tutorial with row generators, source-stats and stories.