Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

29 move tutorial to readthedocs #103

Merged
merged 12 commits into from
Jun 27, 2023
Merged

Conversation

Iain-S
Copy link
Collaborator

@Iain-S Iain-S commented Jun 21, 2023

Add an end-to-end tutorial with row generators, source-stats and stories.

@Iain-S Iain-S requested review from mhauru and myyong June 21, 2023 13:26
@Iain-S
Copy link
Collaborator Author

Iain-S commented Jun 21, 2023

@mhauru @myyong could one or other of you be able to review this PR for us?

Preview here: https://sqlsynthgen--103.org.readthedocs.build/en/103/

Copy link
Collaborator

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I had some comments local to individual lines and paragraphs, but very happy with the overall structure, the example Airbnb case, and all that.

@cptanalatriste cptanalatriste requested a review from mhauru June 22, 2023 15:44
@cptanalatriste
Copy link
Collaborator

I made several changes suggested by @mhauru in the last commits. Please let me know if more edits are required :)

Copy link
Collaborator

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Carlos, I had a couple more comments

@cptanalatriste
Copy link
Collaborator

@mhauru , your comments were addressed in the last commit :)

Copy link
Collaborator

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks Carlos!

@cptanalatriste cptanalatriste merged commit f7efe98 into main Jun 27, 2023
@cptanalatriste cptanalatriste deleted the 29-move-tutorial-to-readthedocs branch June 27, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants