Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(partly) Implement tests for core functionality and add CI #20

Merged
merged 10 commits into from
Apr 19, 2024
Merged

Conversation

rchan26
Copy link
Collaborator

@rchan26 rchan26 commented Apr 18, 2024

Start of testing. Fixes #17 and partly #4

Tests implemented:

  • Settings
  • Experiment
  • Base model classes
    • BaseModel
    • AsyncBaseModel

Also:

  • Add CI for testing and formatting

Remaining tests to complete #4:

  • ExperimentPipeline
  • The 'utils'

The tests for individual models will come at some point too.

@rchan26 rchan26 marked this pull request as draft April 18, 2024 12:57
@rchan26 rchan26 marked this pull request as ready for review April 18, 2024 17:03
@rchan26 rchan26 requested a review from fedenanni April 18, 2024 17:04
@rchan26 rchan26 changed the title Implement tests for core functionality (partly) Implement tests for core functionality Apr 18, 2024
@rchan26 rchan26 changed the title (partly) Implement tests for core functionality (partly) Implement tests for core functionality and add CI Apr 18, 2024
@rchan26 rchan26 mentioned this pull request Apr 19, 2024
Copy link
Collaborator

@fedenanni fedenanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rchan26 all tests pass on my side and all look good

@rchan26 rchan26 merged commit 661945e into main Apr 19, 2024
5 checks passed
@rchan26 rchan26 deleted the ci-test branch April 19, 2024 09:33
rchan26 added a commit that referenced this pull request May 20, 2024
(partly) Implement tests for core functionality and add CI
rchan26 added a commit that referenced this pull request May 20, 2024
(partly) Implement tests for core functionality and add CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI to the repo
2 participants