Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC PYTHON API] Implement read_network #21

Conversation

AlexeyLebedev1
Copy link

Tickets:

  • 51219

@AlexeyLebedev1 AlexeyLebedev1 marked this pull request as draft April 22, 2021 08:20
@AlexeyLebedev1 AlexeyLebedev1 marked this pull request as ready for review April 23, 2021 07:18
@AlexeyLebedev1
Copy link
Author

@jiwaszki Can you please review this PR? It seems I have no permissions in this repo to add you to the reviewers.

@jiwaszki jiwaszki requested review from akuporos and jiwaszki April 23, 2021 07:46
@jiwaszki jiwaszki assigned jiwaszki and AlexeyLebedev1 and unassigned jiwaszki Apr 23, 2021
@AlexeyLebedev1 AlexeyLebedev1 force-pushed the alexeyl1/poc/implement_read_network branch 2 times, most recently from 6bc6cc0 to d1d555e Compare April 23, 2021 09:25
@AlexeyLebedev1 AlexeyLebedev1 requested a review from jiwaszki April 23, 2021 09:35
Copy link

@jiwaszki jiwaszki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AlexeyLebedev1 AlexeyLebedev1 requested a review from jiwaszki April 27, 2021 17:16
Copy link

@jiwaszki jiwaszki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small code style change

array = np.fromfile(path_to_bin_file,dtype=np.uint8)
tensor_desc = TensorDesc("U8", array.shape, "C")
return BlobWrapper(tensor_desc,array)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line here

@AlexeyLebedev1 AlexeyLebedev1 force-pushed the alexeyl1/poc/implement_read_network branch from 383db25 to 2d973d1 Compare April 29, 2021 06:23
@AlexeyLebedev1 AlexeyLebedev1 requested a review from jiwaszki April 29, 2021 06:32
Copy link
Owner

@akuporos akuporos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add the next test which checks read network from buffer:

ie = IECore()
with open(test_net_bin, 'rb') as f:
    bin = f.read()
with open(model_path()[0], 'rb') as f:
    xml = f.read()
net = ie.read_network(model=xml, weights=bin)
assert isinstance(net, IENetwork)

Looks like it'll fail.

@akuporos akuporos force-pushed the mk/ov_pybind_poc branch 3 times, most recently from 847b98b to 71c1b53 Compare May 13, 2021 10:20
@AlexeyLebedev1 AlexeyLebedev1 force-pushed the alexeyl1/poc/implement_read_network branch 2 times, most recently from 49b94f0 to 942ef21 Compare May 13, 2021 16:27
@AlexeyLebedev1 AlexeyLebedev1 requested a review from akuporos May 19, 2021 14:01
@AlexeyLebedev1 AlexeyLebedev1 force-pushed the alexeyl1/poc/implement_read_network branch from 942ef21 to 74a17f1 Compare May 20, 2021 17:57
@akuporos akuporos merged commit 6c6ccd2 into akuporos:mk/ov_pybind_poc May 20, 2021
akuporos added a commit that referenced this pull request Sep 29, 2021
…d_network

[POC PYTHON API] Implement read_network
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants