BUG: override default FromPrimitive implementation for u128 and i128 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default FromPrimitive implementation for
BigDecimal::from_u128andBigDecimal::from_i128goes throughu64andi64respectively, rendering the default implementation useless as any number greater than 64 bits won't be parseable into a 128 bit number. The default implementation currently used can be found here:https://github.com/rust-num/num-traits/blob/4ac94b4136ea06d0bd0e1b8abe30c55a45acffdf/src/cast.rs#L476
I have overridden the default implementation so that this function actually works as intended.