fix: set override correctly for systemd services #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, I had used a priority of 500 thinking that the "default" is 1000. Turns out that Nix sets a priority of 100 to regular assigments. Since the `oci-containers` module sets `Restart=always`, it ends up silently overriding any value set by compose2nix. To fix this, I am bumping down the priority to 90. I've also added an integration test to verify that we indeed override the NixOS module.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
=======================================
Coverage 72.08% 72.08%
=======================================
Files 6 6
Lines 745 745
=======================================
Hits 537 537
Misses 165 165
Partials 43 43 ☔ View full report in Codecov by Sentry. |
aksiksi
added a commit
that referenced
this pull request
Sep 23, 2024
Previously, I had used a priority of 500 thinking that the "default" is 1000. Turns out that Nix sets a priority of 100 to regular assigments. Since the `oci-containers` module sets `Restart=always`, it ends up silently overriding any value set by compose2nix. To fix this, I am bumping down the priority to 90. I've also added an integration test to verify that we indeed override the NixOS module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, I had used a priority of 500 thinking that the "default" is 1000. Turns out that Nix sets a priority of 100 to regular assigments. Since the
oci-containersmodule setsRestart=always, it ends up silently overriding any value set by compose2nix.To fix this, I am bumping down the priority to 90. I've also added an integration test to verify that we indeed override the NixOS module.
Fixes #46.