Use React as a peer dependency #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
reviewed
Jun 3, 2023
|
I introduced some conflicts in your PR with my latest changes on master, please resolve them :) |
This commit sets up the package to use React as a peer dependency. This is the [recommended way](https://stackoverflow.com/a/30454133) to add React to an external library and how many members of the React core team have it setup in [their packages](https://github.com/gaearon/react-side-effect/blob/master/package.json#L33). This means that html-to-react will now leverage the version of React that the user has installed, instead of potentially using a different version within the module if the user is not on React v18. This was causing an increased bundle size when installing `v1.5.1` when compared to `v1.5.0` which this should resolve.
@aknuds1 Thanks for the review, updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up the package to use React as a peer dependency.
This is the recommended way to add React to an external library and how many members of the React core team have it setup in their packages.
This means that html-to-react will now leverage the version of React that the user has installed, instead of potentially using a different version within the module if the user is not on React v18. This was causing an increased bundle size when installing
v1.5.1when compared tov1.5.0which this should resolve.@aknuds1 Thanks again for maintaining this module as it has been extremely useful for handling HTML passed from a sever in a safe and customizable way.