ScalaPB 1.0 and document use of local protoc for OSX ARM #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm really looking forward to sbt-protoc 1.0.0, it will also fix running protoc without further workarounds on NixOS \o/ |
raboof
reviewed
Jan 18, 2021
|
This is similar to #1146 |
Closed
ennru
commented
Jan 19, 2021
project/Common.scala
Outdated
| scalafmtOnCompile := true, | ||
| // https://github.com/akka/akka-grpc/issues/1238 | ||
| PB.protocExecutable := (if (protocbridge.SystemDetector.detectedClassifier() == "osx-aarch_64") | ||
| file("/usr/local/bin/protoc") |
There was a problem hiding this comment.
This should be configurable. Hopefully ScalaPB can offer a good solution for it.
There was a problem hiding this comment.
it's configurable by overriding PB.protocExecutable - perhaps that is sufficient?
There was a problem hiding this comment.
Yes, that should be enough. A note/pointer in the Akka gRPC docs would be good.
ennru
changed the title
raboof
reviewed
Jan 22, 2021
| @@ -106,7 +117,7 @@ If you want to use TLS-based negotiation on JDK 8 versions prior to | |||
| [1.8.0_251](https://www.oracle.com/java/technologies/javase/8u251-relnotes.html), | |||
| the server requires a special Java agent for ALPN. | |||
|
|
|||
| See the [Akka HTTP docs about HTTP/2](https://doc.akka.io/docs/akka-http/10.1/server-side/http2.html#application-layer-protocol-negotiation-alpn-)) | |||
| See the @extref:[Akka HTTP docs about HTTP/2](akka-http:server-side/http2.html#application-layer-protocol-negotiation-alpn-) | |||
raboof
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScalaPB 1.0 (in RC right now) allows setting the
protocexecutable so that a locally built version can be used.References #1238