Skip to content

Bump version of Poison #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2023
Merged

Conversation

frahugo
Copy link
Contributor

@frahugo frahugo commented Jul 13, 2023

Allow Poison 5.0.0 to be used.

frahugo added 2 commits July 13, 2023 09:56
As compilation of Poison 5.0.0 fails in Elixir 1.6.
@frahugo frahugo force-pushed the poison-5-upgrade branch from 6ba03ff to a24b11f Compare July 13, 2023 14:12
@ananthakumaran
Copy link
Collaborator

@frahugo do you know if I can find the changelog somewhere? I am happy to merge it, just wondering if there are any breaking changes that we need to know about.

@frahugo
Copy link
Contributor Author

frahugo commented Jul 13, 2023

@frahugo do you know if I can find the changelog somewhere? I am happy to merge it, just wondering if there are any breaking changes that we need to know about.

@ananthakumaran The CHANGELOG is at the root. I ran the test locally with Poison as the Json library and tests were green. I guess it would not break anything as the json is used to serialize and deserialize data for the jobs. Maybe someone else who uses Poison can jump in?

@ananthakumaran
Copy link
Collaborator

I was asking about poison changelog. Seems like they don't maintain any.

@ananthakumaran ananthakumaran merged commit 5214e7a into akira:master Jul 16, 2023
@frahugo
Copy link
Contributor Author

frahugo commented Jul 17, 2023

I was asking about poison changelog. Seems like they don't maintain any.

Oh sorry, misunderstood. Yeah, they don't have a change log. Thanks for the merge. Could this merge trigger version 0.18.1 and a release on hex.pm? Thanks.

@ananthakumaran
Copy link
Collaborator

@frahugo released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants