Fix potential nil access #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one uses this method mapped to keys and accidentally hit a number with a non-existing buffer, `element` can be nil:
```
E5108: Error executing lua: ...re/nvim/lazy/bufferline.nvim/lua/bufferline/commands.lua:122: attempt to index local 'element' (a nil value)
stack traceback:
...re/nvim/lazy/bufferline.nvim/lua/bufferline/commands.lua:122: in function 'go_to'
```
akinsho
reviewed
Sep 25, 2023
akinsho
reviewed
Sep 25, 2023
| @@ -119,7 +119,10 @@ function M.go_to(num, absolute) | |||
| local list = absolute and state.components or state.visible_components | |||
| local element = list[num] | |||
| if num == -1 or not element then element = list[#list] end | |||
There was a problem hiding this comment.
I'm a bit confused why this check wouldn't be enough already? if element is falsy then it should use the last item in the list?
There was a problem hiding this comment.
If there is only 1 buffer, it appears that there isn't any items in the list.
There was a problem hiding this comment.
If I insert:
vim.notify(vim.inspect(element))
vim.notify(vim.inspect(list))
in between lines 120 and 121, the output is nil and {} respectively.
Co-authored-by: Akin <[email protected]>
sstallion
pushed a commit
to sstallion/bufferline.nvim
that referenced
this pull request
Jul 3, 2024
* Fix potential nil access
If one uses this method mapped to keys and accidentally hit a number with a non-existing buffer, `element` can be nil:
```
E5108: Error executing lua: ...re/nvim/lazy/bufferline.nvim/lua/bufferline/commands.lua:122: attempt to index local 'element' (a nil value)
stack traceback:
...re/nvim/lazy/bufferline.nvim/lua/bufferline/commands.lua:122: in function 'go_to'
```
* Update lua/bufferline/commands.lua
Co-authored-by: Akin <[email protected]>
---------
Co-authored-by: Akin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one uses this method mapped to keys and accidentally hit a number with a non-existing buffer,
elementcan be nil: