-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASM-13755] Fix allowedAccessPermissions Type in Gateway Charts #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OriBenHur-akeyless
approved these changes
Feb 3, 2025
@OriBenHur-akeyless - As this issue is also relevant for the |
It should have a schema also |
michelsk
approved these changes
Feb 5, 2025
OriBenHur-akeyless
approved these changes
Feb 6, 2025
@michelsk @OriBenHur-akeyless - schema added to unified gw as well. Let me know if I can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When deploying a Gateway using either
akeyless-api-gateway
orakeyless-gateway
and filling out theakeylessUserAuth.allowedAccessPermissions
property invalues.yaml
, the comment above the property describes it as a list. However, the default value is an object:When filling this section with a list of access permissions:
And installing it, we get a warning:
helm upgrade akeyless-gw akeyless/akeyless-api-gateway -f values.yaml --install coalesce.go:286: warning: cannot overwrite table with non table for akeyless-api-gateway.akeylessUserAuth.allowedAccessPermissions (map[])
Solution
To remove this warning, this PR introduces a few changes:
allowedAccessPermissions
array in the API gateway chart.values.yaml
was change to a list.values.schema.json
to unified gateway chart.Testing
To test this change, I used the same chart that produced the issue and used the changes in this ref to rerun the installation. As we can see in the output below, the warning is gone: