Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR-003 make arg completion more flexible #1

Merged
merged 3 commits into from
Oct 10, 2023
Merged

PR-003 make arg completion more flexible #1

merged 3 commits into from
Oct 10, 2023

Conversation

jxskiss
Copy link

@jxskiss jxskiss commented Oct 9, 2023 •
edited
Loading

Hi, sorry for the late review.
I made some changes to the code, which let the completion funciton be more flexable.

There are some works left, hope you can help.

  1. review the code
  2. shell scripts should be changed to pass an extra empty string "" to the program when the last word is complete, e.g. "program cmd1 -a [TAB][TAB]" (note the space after "-a"), bash_autocomplete has already been changed.
  3. more tests to cover the various use-case (nice to have, not must)

@jxskiss
PR-003 make arg completion more flexable
2a2d98d 
Change-Id: I303548507a8cde2888a6205f6afe269423b523d9
@jxskiss jxskiss mentioned this pull request Oct 9, 2023
Merged
@jxskiss
PR-003 test ArgCompletionContext and fix bugs
72bb385 
Change-Id: Id76572f4712e8b32994ceecfc58e6f3fa117f7b0
@akemrir akemrir changed the title PR-003 make arg completion more flexable PR-003 make arg completion more flexible Oct 9, 2023
@akemrir
Copy link
Owner

akemrir commented Oct 9, 2023

Ok, sure. Will check today.

@jxskiss
PR-003 tidy code
f4f8a77 
Change-Id: I53bc2d0b32a95a24b50a3722291b5853c201a311
akemrir
akemrir approved these changes Oct 10, 2023
View reviewed changes
Copy link
Owner

@akemrir akemrir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I had tested them on zsh and bash with few minor tweaks.

@akemrir akemrir merged commit e3888d3 into akemrir:PR-003 Oct 10, 2023
@jxskiss jxskiss deleted the akemrir-PR-003-patch branch November 8, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akemrir akemrir akemrir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jxskiss @akemrir