Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXE-2049 use the max-body from edgerc or from optional argument passed to Edge… #1

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 6, 2015

Akamai Forward rewrite Cloudlet api has a max-body size of 131072. The current node implementation uses a hard coded value of 2048. This change allows the value to come from the edgerc file or from the initialization of the EdgeGrid object in api.js.

The default value of 2048 is still used if a value is not passed during initialization.

@ktyacke
Copy link

ktyacke commented Nov 19, 2015

Looks good to me.

@ghost
Copy link
Author

ghost commented Nov 20, 2015

What about current users that have a max-body size in edge.rc that is not 2048. The value will now be picked up. Will this break them?

@ktyacke
Copy link

ktyacke commented Dec 8, 2015

Steve,
Sorry for the delay in comment on this one, finally getting caught up. I think it should work fine, but would you be able to do a quick merge and re-commit your changes so I can pull it down and test?

@ghost
Copy link
Author

ghost commented Dec 8, 2015

I'm at the node conference in Portland, I will try to get to it Friday

On Tuesday, December 8, 2015, ktyacke [email protected] wrote:

Steve,
Sorry for the delay in comment on this one, finally getting caught up. I
think it should work fine, but would you be able to do a quick merge and
re-commit your changes so I can pull it down and test?


Reply to this email directly or view it on GitHub
#1 (comment)
.

@ktyacke
Copy link

ktyacke commented Dec 9, 2015

No worries Steve, thanks! Hope the conference is going well!

@ktyacke
Copy link

ktyacke commented Nov 29, 2016

@stevemcginnis Any interest in pushing forward with this PR?

@majakubiec majakubiec changed the title use the max-body from edgerc or from optional argument passed to Edge… DXE-2049 use the max-body from edgerc or from optional argument passed to Edge… Jan 9, 2023
@mgwoj mgwoj mentioned this pull request Jan 26, 2023
@lkowalsk-akamai-com
Copy link

Hi, since this PR was very old we decided to fix this on our own. The fix is ready with recent release. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants