Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Firefox] Wasavi painfully slow with e10s #144

Closed
Timvde opened this issue Sep 7, 2016 · 6 comments
Closed

[Firefox] Wasavi painfully slow with e10s #144

Timvde opened this issue Sep 7, 2016 · 6 comments
Labels

Comments

@Timvde
Copy link

Timvde commented Sep 7, 2016

When using in an e10s (multi-process) enabled Firefox build, Wasavi slows down the entire browser to a crawl. This is probably due to excessive usage of CPOWs.

More information on https://developer.mozilla.org/en-US/Add-ons/Working_with_multiprocess_Firefox and https://developer.mozilla.org/en-US/Firefox/Multiprocess_Firefox/Limitations_of_chrome_scripts

@akahuku
Copy link
Owner

akahuku commented Feb 8, 2017

Thank you.
The latest wasavi is based on the WebExtensions technology.
So, there should be no interprocess communication by CPOW.

@akahuku akahuku added the bug label Feb 8, 2017
@Timvde
Copy link
Author

Timvde commented Feb 8, 2017

Doesn't seem to work :( Although it's not your fault.

From the browser console:

wasavi backend: ERROR: TypeError: chrome.identity.onSignInChanged is undefined

Which is not supported yet according to Are We WebExtensions Yet?. A quick search on Bugzilla pointed me to bug 1320862.

Going from the Wasavi code, it seems like this has something to do with sync. Is there an easy way to disable it? I don't need (nor want) to sync anything.

@Timvde
Copy link
Author

Timvde commented Feb 11, 2017

Thanks, it's a step closer to working in Firefox! Now the issue is that chrome.tabs.sendRequest is undefined. It is marked as deprecated and replaced by sendMessage. Mozilla has decided not to implement any deprecated APIs.

I would try this myself, since the change seems trivial, but I didn't manage to build the add-on. I installed npm, ran npm install (which ended with errors, it said it could not run distribute-scripts), then ran distribute-scripts myself (no output here at all), and finally make xpi (which failed too). Do you have build instructions somewhere? It is my first time ever I try to build an add-on myself, so sorry if I did something stupid :)

@Timvde
Copy link
Author

Timvde commented Feb 11, 2017

Looks like we're still a way off. Firefox also doesn't support clipboardRead yet.

@akahuku
Copy link
Owner

akahuku commented Feb 12, 2017

I added the document about build and test wasavi:
https://github.com/akahuku/wasavi/blob/master/BUILD-AND-TEST.md

It is not mandatory to build xpi to develop wasavi. Install web-ext with npm, and

$ make debug-firefox

The command launches Firefox for debugging with built-in wasavi.

@Timvde
Copy link
Author

Timvde commented Apr 15, 2017

I just tested the latest unstable release, and it works great on Nightly! Thanks :)

@Timvde Timvde closed this as completed Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants