Fix docs build and move to GitHub Actions #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocefpaf
commented
Jun 19, 2023
Merged
|
I'm not going to pretend I understand every line of this, but I think it makes sense to me and will be an improvement. How are the secrets handled, is there anything that needs creating or is it ready to work once merged? |
No need for special secrets here. GH already have that one pre-defined for you there. In #137 you do need a PyPI token in https://github.com/ajdawson/eofs/pull/137/files#diff-1baea138c19b06c7531655c5e977dbbcca5bd9147709625e2ee40984905502c5R54 but I'll write the steps necessary to create and add it to GH there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm also working on moving the PyPI upload and tests to GitHub Actions. Let me know if that is OK.
The end goal is to get the CIs back online and hopefully mint a new release.