Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #5720

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Cleanup #5720

merged 4 commits into from
Feb 3, 2025

Conversation

nightwing
Copy link
Member

@nightwing nightwing commented Jan 18, 2025

  • excluded esm-resolver.js from linter since it was printing error about using import in non-module, and was preventing embedding ace in cloud-editor
  • converted line endings of some demo files to linux style
  • updated the test to run with typescript latest and 3.7 to prevent introduction of types not compatible with old typescript (3.7 is the oldest version that works with ace atm)
  • updated last case of timeout missed from https://github.com/ajaxorg/ace/pull/5726/files (this change is needed because typescript was generating different types depending on @types/nodjs package being installed in node_modules in some of parent directories)

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.06%. Comparing base (6f05b92) to head (318ea86).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5720   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files         598      598           
  Lines       43713    43713           
  Branches     7164     7164           
=======================================
  Hits        38057    38057           
  Misses       5656     5656           
Flag Coverage Δ
unittests 87.06% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightwing nightwing force-pushed the cleanup branch 2 times, most recently from 748c98e to 0ebb0c7 Compare January 31, 2025 08:17
@whazor
Copy link
Contributor

whazor commented Feb 3, 2025

Could you please add a summary of what changes you did? For example the change types/ace-lib.d.ts could have an impact on an integrator.

The changes itself look good to me.

@nightwing nightwing merged commit ef8b1f0 into master Feb 3, 2025
3 checks passed
@nightwing nightwing deleted the cleanup branch February 3, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants