Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment folding #4910

Merged
merged 3 commits into from
Oct 15, 2022
Merged

Comment folding #4910

merged 3 commits into from
Oct 15, 2022

Conversation

anijanyan
Copy link
Contributor

Issue #, if available:

Fixed comment folding bugs for html (xml like languages)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Base: 85.76% // Head: 86.00% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (5714e7b) compared to base (d5842cb).
Patch coverage: 95.23% of modified lines in pull request are covered.

❗ Current head 5714e7b differs from pull request most recent head d0ed56a. Consider uploading reports for the commit d0ed56a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4910      +/-   ##
==========================================
+ Coverage   85.76%   86.00%   +0.23%     
==========================================
  Files         539      542       +3     
  Lines       40723    41477     +754     
  Branches     6442     6565     +123     
==========================================
+ Hits        34928    35671     +743     
- Misses       5795     5806      +11     
Flag Coverage Δ
unittests 86.00% <95.23%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/keyboard/vim.js 89.86% <93.75%> (+0.32%) ⬆️
src/edit_session/bracket_match.js 93.61% <94.11%> (+0.06%) ⬆️
src/edit_session/folding.js 75.42% <100.00%> (+0.09%) ⬆️
src/keyboard/vim_test.js 98.60% <100.00%> (+0.33%) ⬆️
src/mouse/default_handlers.js 71.50% <100.00%> (ø)
src/mode/css_completions.js 20.00% <0.00%> (-2.50%) ⬇️
src/virtual_renderer.js 79.83% <0.00%> (-0.22%) ⬇️
src/mode/aql_highlight_rules.js 100.00% <0.00%> (ø)
src/layer/decorators.js 97.56% <0.00%> (ø)
src/scrollbar_custom.js 95.15% <0.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@anijanyan anijanyan force-pushed the comment-folding branch 2 times, most recently from bb10abe to d0ed56a Compare October 14, 2022 09:47
@anijanyan anijanyan marked this pull request as ready for review October 14, 2022 09:49
@andrewnester andrewnester merged commit 5279a8a into ajaxorg:master Oct 15, 2022
@andrewnester
Copy link
Contributor

Approved and merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants