Skip to content

Add image link parsing to the Markdown link parsing RegEx #3669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2018

Conversation

RickStrahl
Copy link
Contributor

@RickStrahl RickStrahl commented May 14, 2018

Image link highlighting in mode-markdown seems to not highlight the leading ! character. In some cases this looks OK in others maybe not so much. I think it's probably better to have the entire image formatting use the same colors.

Added in explicit image link handling.

This is what it looks like before:

image

and here it is after the change:

image

The latter seems more consistent.

To be honest this is minor but several of my users have mentioned this (here's one) and looking at the two renderings side by side I do think that the latter looks more consistent.

Note: Resubmitted as a new PR due a face palm on my end on the previous PR #3667. Sorry for the noise.

@codecov
Copy link

codecov bot commented May 14, 2018

Codecov Report

Merging #3669 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3669      +/-   ##
==========================================
- Coverage   66.54%   66.54%   -0.01%     
==========================================
  Files         482      482              
  Lines       47721    47721              
  Branches     9082     9082              
==========================================
- Hits        31755    31754       -1     
- Misses      15966    15967       +1
Impacted Files Coverage Δ
lib/ace/mode/markdown_highlight_rules.js 43.18% <ø> (ø) ⬆️
lib/ace/virtual_renderer.js 68.5% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54ecd9...bb8d406. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants