[WIP] Infinite canvas #3623
Merged
[WIP] Infinite canvas #3623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3623 +/- ##
==========================================
+ Coverage 64.82% 66.41% +1.59%
==========================================
Files 471 472 +1
Lines 47303 47451 +148
Branches 9023 9040 +17
==========================================
+ Hits 30663 31515 +852
+ Misses 16640 15936 -704
Continue to review full report at Codecov.
|
|
Please look into code coverage for this one:
|
fjakobs
force-pushed
the
infinite-canvas
branch
7 times, most recently
from
09ae2c8 to
3ba0b2c
Compare
nightwing
force-pushed
the
infinite-canvas
branch
from
3ba0b2c to
89376c1
Compare
nightwing
force-pushed
the
infinite-canvas
branch
from
89376c1 to
57918f2
Compare
nightwing
force-pushed
the
infinite-canvas
branch
from
57918f2 to
3792573
Compare
nightwing
force-pushed
the
infinite-canvas
branch
2 times, most recently
from
7627883 to
3c6bc8e
Compare
nightwing
force-pushed
the
infinite-canvas
branch
from
3c6bc8e to
2db48da
Compare
nightwing
force-pushed
the
infinite-canvas
branch
from
4da9e49 to
7d58d9c
Compare
fjakobs
commented
Apr 3, 2018
lib/ace/css/editor.css
Outdated
| position: absolute; | ||
| top: 0; | ||
| left: 0; | ||
| right: 0; | ||
| } | ||
|
|
||
| .ace_text-layer .ace_line_group .ace_line { | ||
| position: relative; | ||
| @media (-webkit-min-device-pixel-ratio: 1.5), (min-resolution: 1.5dppx) { |
There was a problem hiding this comment.
Does this mean we only get hw acceleration on retina screens?
There was a problem hiding this comment.
yes, do we need to enable it on mac even if screen is not retina?
fjakobs
commented
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an infinite canvas div to render lines. Offloading scrolling almost entirely to the GPU.