-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: init ping method #1592
Feat: init ping method #1592
Conversation
In redis ping method was already added in the past, can i remove it on tests/broker/test_connect.py and add new method in broker and called it from parent class(brokers/base/connection.py)? As a result, the code will be unified |
For sure |
@Lancetnik, can you view it? I added ping for all brokers |
@kumaranvpl ty. Great point, but I think, we can reuse |
I'll make a change |
Description
Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.
Close #1582
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.sh
shows no errors)scripts/test-cov.sh
scripts/static-analysis.sh