-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(multiprocess): restart child processes if they are not alive #1550
feat(multiprocess): restart child processes if they are not alive #1550
Conversation
|
||
self.processes = active_processes | ||
|
||
def should_restart(self) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we can use smth like not all((p.is_alive() for p in process))
? It looks much explicit for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, it looks better. Fixed
4b56039
to
da0b5a9
Compare
Thank you a lot for contribution and for the framework using! Sorry for waiting for so long (I had a vacation this time) |
Description
Restart child processes in MultiProcessor if the child process terminates for any reason. In our case a process was killed by oom-killer and the faststream app stopped processing events from Kafka.
Fixes # (issue number)
#1059
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.sh
shows no errors)scripts/test-cov.sh
scripts/static-analysis.sh