Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable linting in danger #153

Merged
21 commits merged into from
Mar 26, 2019
Merged

Enable linting in danger #153

21 commits merged into from
Mar 26, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 20, 2019 •
edited by ghost
Loading

Enables linting in danger again, now that we are free (except disabled rules) of warnings, thanks to #151. 📝

Also added the force_unwrapping rule and disabled it where necessary (in the tests mostly).

@ghost ghost added the WIP label Mar 20, 2019
@ghost ghost changed the title Enable linting in danger [WIP] Enable linting in danger Mar 20, 2019
@ghost ghost marked this pull request as ready for review March 20, 2019 14:51
@Jose-ElRobot
Copy link

Jose-ElRobot commented Mar 20, 2019 •
edited
Loading

1 Message
📖 Any non-trivial changes to code should be reflected in the changelog. Please consider adding a note in the Unreleased section of the CHANGELOG.md.

Generated by 🚫 Danger

@ghost ghost changed the title [WIP] Enable linting in danger Enable linting in danger Mar 20, 2019
@ghost ghost removed the WIP label Mar 20, 2019
@ghost ghost self-requested a review March 20, 2019 15:54
@ghost ghost self-assigned this Mar 20, 2019
carol-mohemian
carol-mohemian approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@carol-mohemian carol-mohemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@carol-mohemian carol-mohemian requested a review from a team March 26, 2019 10:38
@ghost ghost merged commit 9cf02d5 into master Mar 26, 2019
@ghost ghost deleted the danger branch March 26, 2019 11:09
@ghost ghost mentioned this pull request Jun 27, 2019
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jose-ElRobot @carol-mohemian @daniel-moh