Do not run excluded tags in integration tests #8715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhizor
approved these changes
Dec 10, 2021
benmoriceau
reviewed
Dec 11, 2021
| @@ -25,7 +25,11 @@ class AirbyteIntegrationTestJavaPlugin implements Plugin<Project> { | |||
| testClassesDirs += project.sourceSets.integrationTestJava.output.classesDirs | |||
| classpath += project.sourceSets.integrationTestJava.runtimeClasspath | |||
|
|
|||
| useJUnitPlatform() | |||
| useJUnitPlatform { | |||
| // todo (cgardens) - figure out how to de-dupe this exclusion with the one in build.gradle. | |||
There was a problem hiding this comment.
One solution would be to make an include list instead and properly annotate the integration test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
S3DocumentStoreClientTestandGcsDocumentStoreClientTest) that was supposed to be run only as part oftools/bin/cloud_storage_logging_test.shwere getting run whenairbyte-workers:integrationTestwas run. This was happening becauseairbyte-integration-test-java.gradleoverrides the exclude tags set inbuild.gradle. This did not affect the other tests run in this script, because the gradle sub modules that those tests were in did not have integration tests.airbyte-workersdoes have integration tests so it was affected.How
explicitly add the exclusions in
airbyte-integration-test-java.gradle. this isn't very pretty, but i couldn't find a more elegant way of doing it, so going with this for now to fix the build.