fail zombie job attempts and add failure reason #8709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
cgardens
approved these changes
Dec 10, 2021
jrhizor
pushed a commit
that referenced
this pull request
Dec 10, 2021
* fail zombie job attempts and add failure reason * remove failure reason
jrhizor
added a commit
that referenced
this pull request
Dec 11, 2021
* upgrade gradle * upgrade to Java 17 (and fix a few of the node versioning misses) * oops * try to run a different format version * fix spotless by upgrading / reformatting some files * fix ci settings * upgrade mockito to avoid other errors * undo bad format * fix "incorrect" sql comments * fmt * add debug flag * remove * bump * bump jooq to a version that has a java 17 dist * fix * remove logs * oops * revert jooq upgrade * fix * set up java for connector test * fix yaml * generate std source tests * fail zombie job attempts and add failure reason (#8709) * fail zombie job attempts and add failure reason * remove failure reason * bump gcp dependencies to pick up grpc update (#8713) * Bump Airbyte version from 0.33.9-alpha to 0.33.10-alpha (#8714) Co-authored-by: jrhizor <[email protected]> * Change CDK "Caching" header to "nested streams & caching" * Update fields in source-connectors specifications: file, freshdesk, github, google-directory, google-workspace-admin-reports, iterable (#8524) Signed-off-by: Sergey Chvalyuk <[email protected]> Co-authored-by: Serhii Chvaliuk <[email protected]> Co-authored-by: Sherif A. Nada <[email protected]> * move S3Config into destination-s3; update dependencies accordingly (#8562) Co-authored-by: Lake Mossman <[email protected]> Co-authored-by: jrhizor <[email protected]> Co-authored-by: Sherif A. Nada <[email protected]> Co-authored-by: Iryna Grankova <[email protected]> Co-authored-by: Serhii Chvaliuk <[email protected]> Co-authored-by: Edward Gao <[email protected]>
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
* fail zombie job attempts and add failure reason * remove failure reason
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
* upgrade gradle * upgrade to Java 17 (and fix a few of the node versioning misses) * oops * try to run a different format version * fix spotless by upgrading / reformatting some files * fix ci settings * upgrade mockito to avoid other errors * undo bad format * fix "incorrect" sql comments * fmt * add debug flag * remove * bump * bump jooq to a version that has a java 17 dist * fix * remove logs * oops * revert jooq upgrade * fix * set up java for connector test * fix yaml * generate std source tests * fail zombie job attempts and add failure reason (airbytehq#8709) * fail zombie job attempts and add failure reason * remove failure reason * bump gcp dependencies to pick up grpc update (airbytehq#8713) * Bump Airbyte version from 0.33.9-alpha to 0.33.10-alpha (airbytehq#8714) Co-authored-by: jrhizor <[email protected]> * Change CDK "Caching" header to "nested streams & caching" * Update fields in source-connectors specifications: file, freshdesk, github, google-directory, google-workspace-admin-reports, iterable (airbytehq#8524) Signed-off-by: Sergey Chvalyuk <[email protected]> Co-authored-by: Serhii Chvaliuk <[email protected]> Co-authored-by: Sherif A. Nada <[email protected]> * move S3Config into destination-s3; update dependencies accordingly (airbytehq#8562) Co-authored-by: Lake Mossman <[email protected]> Co-authored-by: jrhizor <[email protected]> Co-authored-by: Sherif A. Nada <[email protected]> Co-authored-by: Iryna Grankova <[email protected]> Co-authored-by: Serhii Chvaliuk <[email protected]> Co-authored-by: Edward Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Cancelling zombie jobs causes headaches for users, as it charges credits for those jobs and does not naturally restart jobs.
How
Fail the current zombie job attempt instead of cancelling the job. Add a failure reason to indicate why the attempt was failed.