-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Google Analytics V4: Fix window in days validation issue #8676
🐛 Source Google Analytics V4: Fix window in days validation issue #8676
Conversation
/test connector=connectors/source-google-analytics-v4
|
/test connector=connectors/source-google-analytics-v4
|
/test connector=connectors/source-google-analytics-v4
|
/publish connector=connectors/source-google-analytics-v4
|
…rbytehq#8676) * Fix window in days validation issue * Fix urllib.parse.urljoin path parsing bug * Updated catalog to new service test creds * Updated PR number and bumped version in spec yaml and seed * Fix documentation URL
What
#8655 - KeyError('window_in_days') in Google Analytics Source Connector
Setting default value for
window_in_days
was emplimented instream
method, but incheck_connection
method wasTestStreamConnection
but it inherit fromGoogleAnalyticsV4Stream
which during initialization try get value from config dict bywindow_in_days
key before validation instream
method ofSourceGoogleAnalyticsV4
class.How
Shifted
window_in_days
validation fromstream
method to__init__
method ofGoogleAnalyticsV4Stream
class.Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here