🎉 Source Facebook Marketing: Add the option to fetch thumbnail image data. #8649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement IncrementalUnsortedCursorStream to ticket_metrics
for ticket comments and macros
for groups, group memberships and satisfaction ratings
|
@misteryeo can you review the UX change this code makes? |
misteryeo
approved these changes
Dec 15, 2021
| @@ -76,7 +76,9 @@ class Config: | |||
| default_factory=pendulum.now, | |||
| ) | |||
|
|
|||
| include_deleted: bool = Field(default=False, description="Include data from deleted campaigns, ads, and adsets.") | |||
| fetch_thumbnail_images: bool = Field(default=False, description="In each Ad Creative, fetch the thumbnail_url and store the result in thumbnail_data_url") | |||
There was a problem hiding this comment.
Is there any documentation that we can link to from Facebook that demonstrates how this works?
…airbyte into marcos/test-pr-8616
…rif93/airbyte into marcos/test-pr-8622
|
|
github-actions
bot
added
area/documentation
marcosmarxm
force-pushed
the
ping/fetch-creative-thumbnails
branch
from
944ad69 to
8b00071
Compare
marcosmarxm
force-pushed
the
ping/fetch-creative-thumbnails
branch
from
8b00071 to
a481881
Compare
github-actions
bot
removed
normalization
kubernetes
area/scheduler
area/worker
marcosmarxm
force-pushed
the
ping/fetch-creative-thumbnails
branch
from
a481881 to
f2a7124
Compare
github-actions
bot
removed
area/platform
|
Yay thank you!
…On Fri, Dec 17, 2021 at 3:00 PM Marcos Marx ***@***.***> wrote:
Merged #8649 <#8649> into master.
—
Reply to this email directly, view it on GitHub
<#8649 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABZUNX6CF7XH3MWEEL5SLTURO6HJANCNFSM5JU7KOSA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This was referenced Dec 19, 2021
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
…data. (airbytehq#8649) * feat(zendesk): Add Brands and CustomRoles * feat(zendesk): add incremental unsorted cursor stream implement IncrementalUnsortedCursorStream to ticket_metrics * feat(zendesk): use sorted cursor pagination for ticket comments and macros * feat(zendesk): use unsorted cursor stream for groups, group memberships and satisfaction ratings * fix(zendesk): use safe method to get value from nested dict * style(zendesk): reformat using gradlew * fix(zendesk): format created_at and updated_at to date-time format * feat(zendesk): add business hours schedule * bump connector version * bump dockerfile version * reset * resolve webapp files Co-authored-by: asyarif93 <[email protected]> Co-authored-by: Marcos Marx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The Facebook ad_creatives stream contains a
thumbnail_urlfield that points to a thumbnail image of the ad image or ad video. However, the URL in that field is only valid for a short time; it expires after a few days.This change allows you to optionally fetch the contents of the thumbnail image together with the ad_creatives stream. The resulting data is encoded as a
data:URL and placed in the newthumbnail_data_urlfield so you can easily use it as an image source URL.How
fetch_thumbnail_imagessetting in the Facebook Marketing source config.AdCreativesstream post-processes the retrieved record by fetching thethumbnail_url(using therequestslibrary) and encodes the data as adata:URL, which it stores in thethumbnail_data_urlfield.thumbnail_data_urlfield is added to the schema for the ad creatives stream, so that it can be returned in the Airbyte data. However, this field is excluded when requesting data from Facebook, because it's not a field that Facebook knows about.🚨 User Impact 🚨
There are no backward-incompatible changes; upgrading to this version of the Facebook Marketing source should have no effect on existing connections. The
fetch_thumbnail_imagessetting defaults toFalse, and the new behaviour is only enabled when the user changes the setting toTrue.Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described here