SAT: Implement assert that all fields in all streams contained at least one data point #8272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… once in some record.
htrueman
requested review from
Zirochkaa,
sergei-solonitcyn and
yevhenii-ldv
|
tactical suggestion: to avoid breaking all connector builds, we should (temporarily) make this an opt-in flag rather than turned on by default, then create an epic to make it available for all connectors. once a critical mass of connectors is leveraging this option, we should make it turned on by default. WDYT? |
avida
reviewed
Nov 29, 2021
airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py
Outdated
Show resolved
Hide resolved
avida
reviewed
Nov 29, 2021
airbyte-integrations/bases/source-acceptance-test/unit_tests/test_core.py
Outdated
Show resolved
Hide resolved
avida
suggested changes
Nov 29, 2021
Update unit tests for _validate_field_appears_at_least_once.
avida
approved these changes
Nov 30, 2021
Zirochkaa
approved these changes
Nov 30, 2021
…neOf/anyOf choices. Add oneOf/anyOf unit tests.
…ssert-that-all-fields-in-all-streams-contained-at-least-one-data-point
Update CHANGELOG.md
|
/publish connector=bases/source-acceptance-test
|
htrueman
deleted the
htrueman/7967-sat-assert-that-all-fields-in-all-streams-contained-at-least-one-data-point
branch
This was referenced Dec 1, 2021
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
…st one data point (airbytehq#8272) * Implement vlidatation if each field in a stream has appeared it least once in some record. * Add unit tests for `_validate_empty_streams` TestBasicRead method. * Add validate_data_points basic read input option. * Update `_validate_field_appears_at_least_once_in_stream` to support oneOf/anyOf choices. Add oneOf/anyOf unit tests. * Bump docker version. Update CHANGELOG.md * Fix test_core.py imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #7967
How
Updated
TestBasicRead.test_read()with_validate_field_appears_at_least_oncetest.Recommended reading order
airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py🚨 User Impact 🚨
That would require us to fix SAT in all (or almost all) connectors. I think it may be done in the follow up PR.