Refactor MigrationAcceptanceTest to test for major version bumps #8154
Conversation
| .thenReturn(false) | ||
| .thenReturn(false) | ||
| .thenReturn(true); |
There was a problem hiding this comment.
I wasn't aware this was a thing, cool
| logsToExpect.add("Version: 0.17.0-alpha-db-patch"); | ||
| private void runAirbyte(final File dockerComposeFile, | ||
| final Properties env, | ||
| final VoidCallable assertionExecutable, |
There was a problem hiding this comment.
nit: calling this an assertionExecutable feels a little strange to me, because that makes me think that the function passed in should only be executing assertions. However in this PR you pass in the populateDataForFirstRun() function which also loads data into the db. Maybe something like postStartupExecutable would be better?
| majorVersionBumpRun(); | ||
| finalRun(targetVersion); | ||
| // run "faux" major version bump version | ||
| final File version32DockerComposeFile = MoreResources.readResourceAsFile("docker-compose.yaml"); |
There was a problem hiding this comment.
Does the version 0.32.0 docker-compose file also need to be preserved, similar to the docker-compose-migration-test-0-17-0-alpha.yaml file used above?
There was a problem hiding this comment.
good call. i had added the file to source but wasn't referencing it here. will fix.
...cceptanceTest/java/io/airbyte/test/automaticMigrationAcceptance/MigrationAcceptanceTest.java
Show resolved
Hide resolved
cgardens
force-pushed
the
cgardens/improve-auto-migration-test
branch
from
2bc7fc2 to
0f43bf6
Compare
What