Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source MongoDB - Added milliseconds to convert timestamp to datetime format #8046

Merged
merged 4 commits into from
Nov 18, 2021
Merged

🐛 Source MongoDB - Added milliseconds to convert timestamp to datetime format #8046

merged 4 commits into from
Nov 18, 2021

Conversation

andriikorotkov
Copy link
Contributor

@andriikorotkov andriikorotkov commented Nov 17, 2021 •
edited
Loading

What

Added milliseconds to convert timestamp to datetime format.

  • Root case - the pattern we are using for transformation did not support milliseconds.
  • I was able to reproduce the bug locally.
  • I added a new pattern and a new method for converting timestamp.

How

7556-1

7556-2

7556-3

7556-4

7556-5

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 17, 2021
@andriikorotkov andriikorotkov linked an issue Nov 17, 2021 that may be closed by this pull request
Source: MongoDB - Timestamp microseconds missing in Cursor - Incremental change capture #7556
Closed
alexandr-shegeda
alexandr-shegeda approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we can proceed with publish/merge without airbyte review

@alexandr-shegeda alexandr-shegeda marked this pull request as ready for review November 17, 2021 16:44
@andriikorotkov
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
9df0130 
…7556-mongodb-timestamp

� Conflicts:
�	airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/b2e713cd-cc36-4c0a-b5bd-b47cb8a0561e.json
�	airbyte-config/init/src/main/resources/seed/source_definitions.yaml
�	airbyte-integrations/connectors/source-mongodb-v2/Dockerfile
�	docs/integrations/sources/mongodb-v2.md
@andriikorotkov
updated docs
9e2895b
@andriikorotkov
updated docs
4756db6
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Nov 18, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-mongodb-v2

🕑 connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1475908176
✅ connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1475908176
No Python unittests run

@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Nov 18, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-mongodb-strict-encrypt

🕑 connectors/source-mongodb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1475908943
✅ connectors/source-mongodb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1475908943
No Python unittests run

@andriikorotkov andriikorotkov temporarily deployed to more-secrets November 18, 2021 10:14 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 18, 2021 10:15 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 18, 2021 10:15 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Nov 18, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mongodb-v2

🕑 connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1475977300
✅ connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/1475977300

@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Nov 18, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mongodb-strict-encrypt

🕑 connectors/source-mongodb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1475978846
✅ connectors/source-mongodb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1475978846

@jrhizor jrhizor temporarily deployed to more-secrets November 18, 2021 10:35 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 18, 2021 10:35 Inactive
VitaliiMaltsev
VitaliiMaltsev reviewed Nov 18, 2021
View reviewed changes
airbyte-db/lib/src/main/java/io/airbyte/db/DataTypeUtils.java
@@ -37,6 +40,10 @@
}
}

public static String toISO8601StringWithMilliseconds(final long epochMillis) {
return DATE_FORMAT_WITH_MILLISECONDS.format(Date.from(Instant.ofEpochMilli(epochMillis)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from task definition: The cursor should capture the exact data with microseconds
Not milliseconds

@andriikorotkov andriikorotkov temporarily deployed to more-secrets November 18, 2021 11:53 Inactive
@andriikorotkov andriikorotkov merged commit 46e1f65 into master Nov 18, 2021
@andriikorotkov andriikorotkov deleted the akorotkov/7556-mongodb-timestamp branch November 18, 2021 12:30
This was referenced Nov 18, 2021
Merged
Closed
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@andriikorotkov @schlattk
🐛 Source MongoDB - Added milliseconds to convert timestamp to datetim…
355bb8a 
…e format (airbytehq#8046)

* Added milliseconds to convert timestamp to datetime format

* updated docs

* updated docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliiMaltsev VitaliiMaltsev VitaliiMaltsev left review comments

@alexandr-shegeda alexandr-shegeda alexandr-shegeda approved these changes

@sashaNeshcheret sashaNeshcheret Awaiting requested review from sashaNeshcheret

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source: MongoDB - Timestamp microseconds missing in Cursor - Incremental change capture
4 participants
@andriikorotkov @alexandr-shegeda @VitaliiMaltsev @jrhizor