-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Linkedin Ads: support of oAuth2 #7839
Conversation
…zendesk_support/streams.py Co-authored-by: George Claireaux <[email protected]>
Co-authored-by: Sherif A. Nada <[email protected]>
…rbyte into antixar/3732-gsm-ci-secrets
Co-authored-by: Sherif A. Nada <[email protected]>
Co-authored-by: LiRen Tu <[email protected]>
…rbyte into antixar/3732-gsm-ci-secrets
| `string` | `string` | | | ||
| Integration Type | Airbyte Type | Notes | | ||
| :--------------- | :----------- | :------------------------- | | ||
| `number` | `number` | float number | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for formatting.
airbyte-integrations/connectors/source-linkedin-ads/source_linkedin_ads/spec.json
Show resolved
Hide resolved
/test connector=connectors/source-linkedin-ads
|
/test connector=connectors/source-linkedin-ads
|
/publish connector=connectors/source-linkedin-ads
|
* fix 404 responses for the ticket_comments stream * add unit test * add unit test * add oauth2 access token * Update airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py Co-authored-by: George Claireaux <[email protected]> * switching among auth methods * update spec file * update CI secrets logic * remove debug data * add a debug message * fix json convertation * support one secret by several connectors * Update tools/bin/ci_credentials.sh Co-authored-by: LiRen Tu <[email protected]> * update function names * update docs * reset failed changes * update json set value * update spec file * add oauth2 logic * update doc and version * add tests * correction of spec * update tests * update spec file Co-authored-by: Maksym Pavlenok <[email protected]> Co-authored-by: George Claireaux <[email protected]> Co-authored-by: Sherif A. Nada <[email protected]> Co-authored-by: LiRen Tu <[email protected]>
How
Add an implementation of oAuth2 logic to the connector and the Java server part
Manual result of tests:
Pre-merge Checklist
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here