Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix 'Hubspot' -> 'HubSpot' #7683

Merged
merged 4 commits into from
Nov 9, 2021
Merged

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Nov 5, 2021

Signed-off-by: Sergey Chvalyuk [email protected]

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr grubberr linked an issue Nov 5, 2021 that may be closed by this pull request
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation area/frontend area/platform issues related to the platform labels Nov 5, 2021
@grubberr grubberr self-assigned this Nov 5, 2021
@grubberr grubberr temporarily deployed to more-secrets November 5, 2021 19:28 Inactive
Signed-off-by: Sergey Chvalyuk <[email protected]>
@grubberr grubberr temporarily deployed to more-secrets November 5, 2021 19:42 Inactive
@grubberr grubberr temporarily deployed to more-secrets November 9, 2021 09:37 Inactive
@antixar
Copy link
Contributor

antixar commented Nov 9, 2021

This is typo issue and its fix is obvious.
@grubberr, please, publish and merge it

@grubberr
Copy link
Contributor Author

grubberr commented Nov 9, 2021

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1440774292
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1440774292
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  896    440    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                         Stmts   Miss  Cover
	 ------------------------------------------------
	 source_hubspot/__init__.py       2      0   100%
	 source_hubspot/api.py          406     89    78%
	 source_hubspot/client.py        40     12    70%
	 source_hubspot/errors.py         6      0   100%
	 source_hubspot/source.py         4      0   100%
	 ------------------------------------------------
	 TOTAL                          458    101    78%

@jrhizor jrhizor temporarily deployed to more-secrets November 9, 2021 18:09 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented Nov 9, 2021

/publish connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1440859381
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1440859381

@jrhizor jrhizor temporarily deployed to more-secrets November 9, 2021 18:33 Inactive
@grubberr grubberr merged commit 1b38fc7 into master Nov 9, 2021
@grubberr grubberr deleted the grubberr/7671-source-hubspot branch November 9, 2021 18:43
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* bugfix 'Hubspot' -> 'HubSpot'

Signed-off-by: Sergey Chvalyuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "Hubspot" source connector name to "HubSpot"
4 participants