Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish new source Confluence #7241 #7666

Merged
merged 14 commits into from
Nov 5, 2021
Merged

Conversation

harshithmullapudi
Copy link
Contributor

@harshithmullapudi harshithmullapudi commented Nov 5, 2021

What

publish #7241

And removing Audit stream from configured_catalog as we don't have access to that API in free mode

{
    "statusCode": 500,
    "data": {
        "authorized": false,
        "valid": true,
        "errors": [],
        "successful": false
    },
    "message": "com.atlassian.confluence.api.service.exceptions.ServiceException: Cannot fetch audit records because you are on Free edition. Please upgrade to standard or premium if you would like to fetch audit records."
}

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Nov 5, 2021
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Nov 5, 2021

/test connector=connectors/source-confluence

🕑 connectors/source-confluence https://github.com/airbytehq/airbyte/actions/runs/1424741989
❌ connectors/source-confluence https://github.com/airbytehq/airbyte/actions/runs/1424741989
🐛

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets November 5, 2021 07:19 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 5, 2021 07:22 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Nov 5, 2021

/test connector=connectors/source-confluence

🕑 connectors/source-confluence https://github.com/airbytehq/airbyte/actions/runs/1424781490
❌ connectors/source-confluence https://github.com/airbytehq/airbyte/actions/runs/1424781490
🐛 https://gradle.com/s/qqt2eaausmszi

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets November 5, 2021 07:37 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 5, 2021 07:38 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Nov 5, 2021

/test connector=connectors/source-confluence

🕑 connectors/source-confluence https://github.com/airbytehq/airbyte/actions/runs/1424850537
✅ connectors/source-confluence https://github.com/airbytehq/airbyte/actions/runs/1424850537
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       33     22    33%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  891    435    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                            Stmts   Miss  Cover
	 ---------------------------------------------------
	 source_confluence/__init__.py       2      0   100%
	 source_confluence/source.py        77     19    75%
	 ---------------------------------------------------
	 TOTAL                              79     19    76%

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets November 5, 2021 08:05 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 5, 2021 08:06 Inactive
@CLAassistant
Copy link

CLAassistant commented Nov 5, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/frontend area/platform issues related to the platform area/protocol area/scheduler area/server area/worker Related to worker CDK Connector Development Kit labels Nov 5, 2021
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets November 5, 2021 09:05 Inactive
@github-actions github-actions bot removed area/server area/protocol CDK Connector Development Kit area/worker Related to worker normalization area/scheduler area/frontend area/platform issues related to the platform labels Nov 5, 2021
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets November 5, 2021 09:08 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Nov 5, 2021

/test connector=connectors/source-confluence

🕑 connectors/source-confluence https://github.com/airbytehq/airbyte/actions/runs/1425041881
✅ connectors/source-confluence https://github.com/airbytehq/airbyte/actions/runs/1425041881
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                            Stmts   Miss  Cover
	 ---------------------------------------------------
	 source_confluence/__init__.py       2      0   100%
	 source_confluence/source.py        79     19    76%
	 ---------------------------------------------------
	 TOTAL                              81     19    77%

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets November 5, 2021 09:09 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 5, 2021 09:10 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Nov 5, 2021

/publish connector=connectors/source-confluence

🕑 connectors/source-confluence https://github.com/airbytehq/airbyte/actions/runs/1425068735
❌ connectors/source-confluence https://github.com/airbytehq/airbyte/actions/runs/1425068735

@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets November 5, 2021 09:19 Inactive
@harshithmullapudi
Copy link
Contributor Author

harshithmullapudi commented Nov 5, 2021

/publish connector=connectors/source-confluence

🕑 connectors/source-confluence https://github.com/airbytehq/airbyte/actions/runs/1425096259
❌ connectors/source-confluence https://github.com/airbytehq/airbyte/actions/runs/1425096259

@jrhizor jrhizor temporarily deployed to more-secrets November 5, 2021 09:27 Inactive
@harshithmullapudi harshithmullapudi merged commit af1c62f into master Nov 5, 2021
@harshithmullapudi harshithmullapudi deleted the harshith/test-pr-7241 branch November 5, 2021 09:47
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets November 5, 2021 09:48 Inactive
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* initial commit

* add remaining streams

* fix warning and unit test

* clean up

* revert unrelated files

* remove state files

* lint

* add documentation strings

* added confluence credentials to ci

* fix: removed audit from configured catalog as it cannot be pulled in free account

* fix: format

Co-authored-by: Tuan Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants