Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish PR 6967: new source freshservices #7470

Merged
merged 21 commits into from
Oct 29, 2021
Merged

Publish PR 6967: new source freshservices #7470

merged 21 commits into from
Oct 29, 2021

Conversation

marcosmarxm
Copy link
Member

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

tuanchris and others added 20 commits October 12, 2021 13:49
@tuanchris
add first table
d093148
@tuanchris
add other sources and incremental sync
70e6547
@tuanchris
clean up
c68e6d5
@tuanchris
fix schema
64d52c5
@tuanchris
fix unit tests and linting
d20843f
@tuanchris @Zirochkaa
Update airbyte-integrations/connectors/source-freshservice/integratio…
48e0f0a 
…n_tests/invalid_config.json

Co-authored-by: oleh.zorenko <[email protected]>
@tuanchris @Zirochkaa
Update airbyte-integrations/connectors/source-freshservice/Dockerfile
d177196 
Co-authored-by: oleh.zorenko <[email protected]>
@tuanchris @Zirochkaa
Update airbyte-integrations/connectors/source-freshservice/setup.py
876134b 
Co-authored-by: oleh.zorenko <[email protected]>
@tuanchris
clean up
5838f45
@tuanchris
Merge branch '55-freshservice-source' of github.com:tuanchris/airbyte…
cc16eef 
… into 55-freshservice-source
@tuanchris
change schema & more clean up
d8f5c04
@tuanchris
final touch
24a7fb8
@tuanchris
add null for object and array
4931523
@tuanchris
final touch
63344ed
@tuanchris
fix config
a5e6417
@tuanchris
fix integration test
5a09ee6
@marcosmarxm
Merge branch '55-freshservice-source' of github.com:tuanchris/airbyte…
b2bc1a5 
… into marcos/test-pr-6967
@tuanchris
add unit test
ccce6df
@marcosmarxm
Merge branch 'master' into marcos/test-pr-6967
37f41c3
@marcosmarxm
Merge branch '55-freshservice-source' of github.com:tuanchris/airbyte…
d307d97 
… into marcos/test-pr-6967
@github-actions github-actions bot added the area/connectors Connector related issues label Oct 29, 2021
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Oct 29, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-freshservice

🕑 connectors/source-freshservice https://github.com/airbytehq/airbyte/actions/runs/1396971395
❌ connectors/source-freshservice https://github.com/airbytehq/airbyte/actions/runs/1396971395
🐛 https://gradle.com/s/qzss4ihnhwjhs

@jrhizor jrhizor temporarily deployed to more-secrets October 29, 2021 00:27 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Oct 29, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-freshservice

🕑 connectors/source-freshservice https://github.com/airbytehq/airbyte/actions/runs/1396995923
✅ connectors/source-freshservice https://github.com/airbytehq/airbyte/actions/runs/1396995923
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                              Stmts   Miss  Cover
	 -----------------------------------------------------
	 source_freshservice/__init__.py       2      0   100%
	 source_freshservice/source.py        26      0   100%
	 source_freshservice/streams.py       70      9    87%
	 -----------------------------------------------------
	 TOTAL                                98      9    91%

@jrhizor jrhizor temporarily deployed to more-secrets October 29, 2021 00:37 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Oct 29, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-freshservice

🕑 connectors/source-freshservice https://github.com/airbytehq/airbyte/actions/runs/1397033634
✅ connectors/source-freshservice https://github.com/airbytehq/airbyte/actions/runs/1397033634

@marcosmarxm marcosmarxm temporarily deployed to more-secrets October 29, 2021 00:50 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 29, 2021 00:52 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets October 29, 2021 01:06 Inactive
@marcosmarxm marcosmarxm merged commit ab95855 into master Oct 29, 2021
@marcosmarxm marcosmarxm deleted the marcos/test-pr-6967 branch October 29, 2021 01:22
@jrhizor jrhizor mentioned this pull request Nov 1, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@marcosmarxm @tuanchris
@Zirochkaa @schlattk
Publish PR 6967: new source freshservices (airbytehq#7470)
24c9ba4 
* add first table

* add other sources and incremental sync

* clean up

* fix schema

* fix unit tests and linting

* Update airbyte-integrations/connectors/source-freshservice/integration_tests/invalid_config.json

Co-authored-by: oleh.zorenko <[email protected]>

* Update airbyte-integrations/connectors/source-freshservice/Dockerfile

Co-authored-by: oleh.zorenko <[email protected]>

* Update airbyte-integrations/connectors/source-freshservice/setup.py

Co-authored-by: oleh.zorenko <[email protected]>

* clean up

* change schema & more clean up

* final touch

* add null for object and array

* final touch

* fix config

* fix integration test

* add unit test

* bump connector version and format files

Co-authored-by: Tuan Nguyen <[email protected]>
Co-authored-by: oleh.zorenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/source/freshservice connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcosmarxm @jrhizor @igrankova @tuanchris