remove py from fe e2e test build #7361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
commented
Oct 25, 2021
| @@ -326,13 +326,6 @@ jobs: | |||
| with: | |||
| node-version: '14.7' | |||
|
|
|||
| - uses: actions/setup-python@v2 | |||
There was a problem hiding this comment.
FE tests don't need it!
cgardens
commented
Oct 25, 2021
| @@ -414,13 +407,6 @@ jobs: | |||
| with: | |||
| node-version: '14.7' | |||
|
|
|||
| - uses: actions/setup-python@v2 | |||
There was a problem hiding this comment.
kube acceptance test don't need it!
cgardens
commented
Oct 25, 2021
| @@ -193,14 +193,14 @@ jobs: | |||
| ${{ secrets.CACHE_VERSION }}-npm-${{ runner.os }}- | |||
|
|
|||
| # this intentionally does not use restore-keys so we don't mess with gradle caching | |||
| - name: Gradle and Python Caching | |||
| - name: Gradle Caching | |||
There was a problem hiding this comment.
platform build doesn't need to think about python caching anymore!
cgardens
commented
Oct 25, 2021
| @@ -52,13 +52,6 @@ jobs: | |||
| with: | |||
| node-version: '14.7' | |||
|
|
|||
| - uses: actions/setup-python@v2 | |||
There was a problem hiding this comment.
these kube tests don't need python either!
jrhizor
approved these changes
Oct 25, 2021
| @@ -193,14 +193,14 @@ jobs: | |||
| ${{ secrets.CACHE_VERSION }}-npm-${{ runner.os }}- | |||
|
|
|||
| # this intentionally does not use restore-keys so we don't mess with gradle caching | |||
| - name: Gradle and Python Caching | |||
| - name: Gradle Caching | |||
| uses: actions/cache@v2 | |||
| with: | |||
| path: | | |||
| ~/.gradle/caches | |||
| ~/.gradle/wrapper | |||
| **/.venv | |||
.github/workflows/gradle.yml
Outdated
| uses: actions/cache@v2 | ||
| with: | ||
| path: | | ||
| ~/.gradle/caches | ||
| ~/.gradle/wrapper | ||
| **/.venv | ||
| key: ${{ secrets.CACHE_VERSION }}-${{ runner.os }}-${{ hashFiles('**/*.gradle*') }}-${{ hashFiles('**/package-lock.json') }}-${{ hashFiles('**/setup.py') }}-${{ hashFiles('**/requirements.txt') }} | ||
| key: ${{ secrets.CACHE_VERSION }}-${{ runner.os }}-${{ hashFiles('**/*.gradle*') }}-${{ hashFiles('**/package-lock.json') }}-${{ hashFiles('**/requirements.txt') }} |
There was a problem hiding this comment.
Suggested change
| key: ${{ secrets.CACHE_VERSION }}-${{ runner.os }}-${{ hashFiles('**/*.gradle*') }}-${{ hashFiles('**/package-lock.json') }}-${{ hashFiles('**/requirements.txt') }} | |
| key: ${{ secrets.CACHE_VERSION }}-${{ runner.os }}-${{ hashFiles('**/*.gradle*') }}-${{ hashFiles('**/package-lock.json') }} }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Noticed in this PR: #7219 that the build was failing because python didn't install properly when setting up the FE E2E Tests. Those tests son't need python anyway, so... bye bye. Knocked it out a couple other places where I thought it was no longer needed.