prefer AirbyteVersion over String #7310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
AirbyteVersion
to make it easy to interact with versions and perform various operations on them. Throughout the codebase though, we tend pass the version around as aString
. We need to lean into this abstraction. It gives us type safety guarantees. It also allows us to push noisy serialization issues out to the edge of our system. With the string, there were a lot of odd checks to make sure it was not empty and such deep in our internals.AirbyteVersion
instead ofString
.How
String
usages, replace withAirbyteVersion
airbyte-migrations
submodule as that was going to be a real pain, and we plan to remove it soon anyway.