Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move file migration logic in ServerApp to its own method and mark as … #7307

Merged
merged 2 commits into from
Oct 30, 2021
Merged

move file migration logic in ServerApp to its own method and mark as … #7307

merged 2 commits into from
Oct 30, 2021

Conversation

cgardens
Copy link
Contributor

…deprecated

relates to #6917

What

  • This PR just bundles up some of the file migration logic and makes it clear that it is deprecated. The goal is that it will be very straight forward to remove when the time comes and in the meanwhile it will be obvious that it should be ignored.

@cgardens cgardens temporarily deployed to more-secrets October 23, 2021 23:15 Inactive
@github-actions github-actions bot added area/platform issues related to the platform area/server labels Oct 23, 2021
@cgardens cgardens mentioned this pull request Oct 25, 2021
Closed
@cgardens cgardens requested review from lmossman and jrhizor October 26, 2021 00:27
@cgardens cgardens force-pushed the cgardens/deprecate-file-migration branch from 366f164 to e7b35c7 Compare October 30, 2021 01:50
@cgardens cgardens temporarily deployed to more-secrets October 30, 2021 01:51 Inactive
@cgardens cgardens temporarily deployed to more-secrets October 30, 2021 07:06 Inactive
@cgardens cgardens merged commit 8d95cb8 into master Oct 30, 2021
@cgardens cgardens deleted the cgardens/deprecate-file-migration branch October 30, 2021 22:48
@jrhizor jrhizor mentioned this pull request Nov 1, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@cgardens @schlattk
move file migration logic in ServerApp to its own method and mark as … (
6c05df1 
airbytehq#7307)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmossman lmossman Awaiting requested review from lmossman

@jrhizor jrhizor Awaiting requested review from jrhizor

Assignees
No one assigned
Labels
area/platform issues related to the platform area/server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cgardens