Detailed *not* to use username/pass here #7297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Constructing the
DATABASE_URLwas a sharp edge that tripped me up for a few hours when deploying to RDS. Coming from a world where you would provide a fully qualifiedDATABASE_URL(Rails, Phoenix Framework) I assumed I could do the same here.The error message returned in the console was to do with a database connection but didn't mention anything further than that. I was stumped as I was able to successfully test the connection using
psqlbut couldn't get AirByte to function until I realised I need to omit the username and password.How
As well as detailing how to construct the URL, I think it should explicitly mention keeping the username and password out of the URL.