Fix more typos in the docs #7225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/documentation
benmoriceau
approved these changes
Oct 20, 2021
lmossman
commented
Oct 20, 2021
| @@ -59,7 +59,7 @@ The `read` command will emit a stream records to stdout. | |||
| spec() -> ConnectorSpecification | |||
| check(Config) -> AirbyteConnectionStatus | |||
| discover(Config) -> AirbyteCatalog | |||
| read(Config, AirbyteCatalog, State) -> Stream<AirbyteMessage> | |||
| read(Config, ConfiguredAirbyteCatalog, State) -> Stream<AirbyteMessage> | |||
There was a problem hiding this comment.
@cgardens to make a similar update to the write side, with information about write outputting State messages
benmoriceau
approved these changes
Oct 20, 2021
|
thank you! |
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
* Fix more typos in the docs * fix another typo * add "to" * make "example" plural * remove extra words * add period * remove extra "the" * use `source_defined_cursor` instead of `cursor_field` for `AirbyteStream` * Use ConfiguredAirbyteCatalog instead of AirbyteCatalog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix some more typos I've found in the docs to make them less confusing.
How
Recommended reading order
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/SUMMARY.mddocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereUpdating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereConnector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes