Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Google Directory: Add organizations and phones to users schema #7167

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

yevhenii-ldv
Copy link
Contributor

What

copy of #6901, created for publish new version.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 19, 2021
@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets October 19, 2021 13:38 Inactive
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Oct 19, 2021

/test connector=connectors/source-google-directory

🕑 connectors/source-google-directory https://github.com/airbytehq/airbyte/actions/runs/1359388812
✅ connectors/source-google-directory https://github.com/airbytehq/airbyte/actions/runs/1359388812
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                  Stmts   Miss  Cover
	 ---------------------------------------------------------
	 main_dev.py                               6      6     0%
	 source_google_directory/__init__.py       2      2     0%
	 /actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-google-directory/.venv/lib/python3.8/site-packages/coverage/control.py:761: CoverageWarning: No data was collected. (no-data-collected)
	 source_google_directory/api.py           74     74     0%
	 source_google_directory/client.py        24     24     0%
	   self._warn("No data was collected.", slug="no-data-collected")
	 source_google_directory/source.py         4      4     0%
	 source_google_directory/utils.py          3      3     0%
	 ---------------------------------------------------------
	 TOTAL                                   113    113     0%

@jrhizor jrhizor temporarily deployed to more-secrets October 19, 2021 13:41 Inactive
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Oct 19, 2021

/publish connector=connectors/source-google-directory

🕑 connectors/source-google-directory https://github.com/airbytehq/airbyte/actions/runs/1359430818
✅ connectors/source-google-directory https://github.com/airbytehq/airbyte/actions/runs/1359430818

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 19, 2021
@yevhenii-ldv yevhenii-ldv requested a review from avida October 19, 2021 13:50
@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets October 19, 2021 13:50 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 19, 2021 13:51 Inactive
@yevhenii-ldv yevhenii-ldv merged commit 25110c1 into master Oct 19, 2021
@yevhenii-ldv yevhenii-ldv deleted the ykurochkin/publish-pull-request-6901 branch October 19, 2021 13:59
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
…bytehq#7167)

* Google Directory: Add organizations and phones to users schema

https://developers.google.com/admin-sdk/directory/v1/guides/manage-users#json-response

* bump version, add changelogs to google-directory.md

Co-authored-by: Xiangxuan Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants