Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Facebook Pages: bump FB API version #7128

Merged
merged 3 commits into from
Oct 22, 2021
Merged

🎉 Source Facebook Pages: bump FB API version #7128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a48f75a
Upd FB API version
gaart Oct 18, 2021
919a348
Upd changelog
gaart Oct 18, 2021
5fef867
Exclude fields with extra permissions required
gaart Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ain/resources/config/STANDARD_SOURCE_DEFINITION/010eb12f-837b-4685-892d-0a39f76a98f5.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"sourceDefinitionId": "010eb12f-837b-4685-892d-0a39f76a98f5",
"name": "Facebook Pages",
"dockerRepository": "airbyte/source-facebook-pages",
"dockerImageTag": "0.1.1",
"dockerImageTag": "0.1.2",
"documentationUrl": "https://hub.docker.com/r/airbyte/source-facebook-pages",
"icon": "facebook.svg"
}
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@
- sourceDefinitionId: 010eb12f-837b-4685-892d-0a39f76a98f5
name: Facebook Pages
dockerRepository: airbyte/source-facebook-pages
dockerImageTag: 0.1.1
dockerImageTag: 0.1.2
documentationUrl: https://hub.docker.com/r/airbyte/source-facebook-pages
icon: facebook.svg
sourceType: api
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-facebook-pages/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.1
LABEL io.airbyte.version=0.1.2
LABEL io.airbyte.name=airbyte/source-facebook-pages
3 changes: 0 additions & 3 deletions airbyte-integrations/connectors/source-facebook-pages/source_facebook_pages/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@
"category_list",
"checkins",
"company_overview",
"connected_instagram_account",
"connected_page_backed_instagram_account",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've removed these fields because updated API requires new permissions to access them.
Should we ask users to re-generate their tokens instead? Or removing these fields is ok?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt we update scopes for oauth?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We should ask users to regenerate their token. For OSS users this should be pretty straightforward, and since this isn't yet on Cloud then there are no tokens to regenerate. But we have to be super clear about the action required from users in the changelog, because the changelog will be the source of truth for users
  2. We should update oauth scopes accordingly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like in addition to updating permissions and regenerating the token user needs to create and connect an Instagram business account, as well as accept an additional user agreement. What should we do in this case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh crap. Ok let's remove this then. Not all pages will have a connected instagram profiel.

"contact_address",
"country_page_likes",
Expand Down Expand Up @@ -157,7 +156,6 @@
"hours",
"impressum",
"influences",
"instagram_business_account",
"is_always_open",
"is_chain",
"is_community_page",
Expand Down Expand Up @@ -241,7 +239,6 @@
"call_to_actions",
"canvas_elements",
"commerce_merchant_settings",
"custom_labels",
"events",
"feed",
"global_brand_children",
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-facebook-pages/source_facebook_pages/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@


class FacebookPagesStream(HttpStream, ABC):
url_base = "https://graph.facebook.com/v11.0/"
url_base = "https://graph.facebook.com/v12.0/"
primary_key = "id"
data_field = "data"

Expand Down
2 changes: 1 addition & 1 deletion docs/integrations/sources/facebook-pages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,6 @@ You can easily get the page id from the page url. For example, if you have a pag

| Version | Date | Pull Request | Subject |
| :--- | :--- | :--- | :--- |
| 0.1.2 | 2021-10-18 | [7128](https://github.com/airbytehq/airbyte/pull/7128) | Upgrade Facebook API to v.12 |
| 0.1.1 | 2021-09-30 | [6438](https://github.com/airbytehq/airbyte/pull/6438) | Annotate Oauth2 flow initialization parameters in connector specification |
| 0.1.0 | 2021-09-01 | [5158](https://github.com/airbytehq/airbyte/pull/5158) | Initial Release |