Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source GitLab: allow all domains to be used as api_url #7108

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

Zirochkaa
Copy link
Contributor

@Zirochkaa Zirochkaa commented Oct 18, 2021

What

Closes #3265.

Pre-merge Checklist

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

@Zirochkaa Zirochkaa self-assigned this Oct 18, 2021
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 18, 2021
@Zirochkaa Zirochkaa temporarily deployed to more-secrets October 18, 2021 05:28 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Oct 18, 2021

/test connector=source-gitlab

🕑 source-gitlab https://github.com/airbytehq/airbyte/actions/runs/1353251589
✅ source-gitlab https://github.com/airbytehq/airbyte/actions/runs/1353251589
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-gitlab/.venv/lib/python3.8/site-packages/coverage/control.py:761: CoverageWarning: No data was collected. (no-data-collected)
	 -----------------------------------------------
	   self._warn("No data was collected.", slug="no-data-collected")
	 source_gitlab/__init__.py       2      2     0%
	 source_gitlab/source.py        36     36     0%
	 source_gitlab/streams.py      220    220     0%
	 -----------------------------------------------
	 TOTAL                         258    258     0%

@jrhizor jrhizor temporarily deployed to more-secrets October 18, 2021 05:30 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Oct 18, 2021

/publish connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/1354793564
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/1354793564

@Zirochkaa Zirochkaa temporarily deployed to more-secrets October 18, 2021 13:17 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 18, 2021 13:18 Inactive
@Zirochkaa Zirochkaa merged commit cf04b8b into master Oct 18, 2021
@Zirochkaa Zirochkaa deleted the oleh/3265-gitlab-custom-domains branch October 18, 2021 13:24
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
…#7108)

* Remove `pattern` field from `api_url` in spec file

* Bump connector's version + update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/gitlab connectors/sources-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitlab CE on premise instance issues.
5 participants