Set a timeout on kube pod process integration tests to prevent a hang #7087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airbyte-jenny
changed the title
jrhizor
approved these changes
Oct 15, 2021
| @@ -148,7 +152,7 @@ public void testKillingWithoutHeartbeat() throws Exception { | |||
| server.stop(); | |||
|
|
|||
| // waiting for process | |||
| process.waitFor(); | |||
| process.waitFor(2, TimeUnit.MINUTES); | |||
There was a problem hiding this comment.
Can we leave this as-is? Internally we call process.waitFor(); and I'd like to make sure the same thing is tested here in case behavior diverges
There was a problem hiding this comment.
It should timeout if the test takes too long anyways, right?
jrhizor
approved these changes
Oct 25, 2021
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
…airbytehq#7087) * Improved logging for troubleshooting. * Limiting the number of tests for faster iteration testing. * Re-enable tests * Removed unnecessary logging from troubleshooting * Formatting * whitespace * Eliminated duplicate timeout. * Whitespace/formatting * Show logs when a sync job fails during testing. * Formatting * Use alphanumeric random string, not bytes, to test paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Sets a timeout for KubePodProcessIntegrationTest because it uses some infinite-loop child processes, and if the test case fails, those need to be aborted for the overall script to progress. This protected from a hang condition that is sometimes observed.
How
Adds a class-level timeout to the integration test. The duration of the wait time (2 minutes) is an estimate and open to change.