add docs on how to set up ide to automatically add final #7083
Conversation
github-actions
bot
added
the
area/documentation
| 6. You're done! | ||
| 6. We add the `final` keyword wherever possible. It's a drag to have to do it manually, however, so we set up the IDE to do it for us. You can either set this as the default for your IDE or you can set it just for the Airbyte project(s) that you are using. | ||
| 1. Turn on the inspection. Go into project settings... | ||
| 1. Editor > Inspections > Search "Field may be 'final'" > check the box |
There was a problem hiding this comment.
I think that the search result are too large. It may be better to explicitly git the path in the tree (java > coding style issues > [The 2 suggested search])
There was a problem hiding this comment.
i'll add a note to search with the double quotes included. if you include the double quotes in the search then it should only return one result.
| 3. Apply the changes. | ||
| 2. Turn on the auto add final. Go into project settings... | ||
| 1. Plugins - install Save Actions if not already installed. | ||
| 2. Go to Save Actions |
There was a problem hiding this comment.
This is pretty clear to me. First I was confused by the fact that I am using the build in IntelliJ tool (Tools > Actions on Save). I disabled the build in order to use the functionalities provided by save on Actions. I have also checked the optimize import and reformat file.
There was a problem hiding this comment.
added an explanation differentiating the 2.
What
Pre-Merge Checklist
finalkeywords (add final for params, local variables, and fields #7084)