🐛 Airbyte CDK: transforming Python log levels to Airbyte protocol log levels #7024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irbyte protocol log levels
davinchia
reviewed
Oct 14, 2021
|
@davinchia I will create additional test. |
# Conflicts: # airbyte-cdk/python/CHANGELOG.md
davinchia
reviewed
Oct 18, 2021
| @@ -44,10 +44,8 @@ class Config: | |||
|
|
|||
| class Level(Enum): | |||
| FATAL = "FATAL" | |||
| CRITICAL = "CRITICAL" | |||
There was a problem hiding this comment.
what about the critical log level?
There was a problem hiding this comment.
@davinchia I transform levels by them numeric value. CRITICAL numeric value is equal to FATAL numeric value and will be transform to FATAL.
There was a problem hiding this comment.
do we have a test for that I am missing?
There was a problem hiding this comment.
@davinchia I've added test for transforming CRITICAL level
davinchia
approved these changes
Oct 22, 2021
# Conflicts: # airbyte-cdk/python/CHANGELOG.md # airbyte-cdk/python/setup.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improving PR #6085. Remove adding Python log levels to Airbyte protocol, instead transform them to the Airbyte protocol log levels.
How
Changed method "format" of AirbyteLogFormatter. Mapping Python log levels with Airbyte protocol log levels.