Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Create a secure-only Oracle Source #6898

Merged
merged 18 commits into from
Oct 13, 2021

Conversation

andriikorotkov
Copy link
Contributor

What

Create a secure-only Oracle Source

How

Create a new secure-only Oracle Source with 2 options to Oracle source spec : Oracle Native Network Encryption and TLS(Server certificate verification)
135823267-66b8a13a-0521-4674-81c0-e7346055b33b
135823317-f23920a2-cd9f-4265-821c-05803a55129e

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

vmaltsev and others added 16 commits October 1, 2021 16:19
# Conflicts:
#	docs/integrations/sources/oracle.md
…q/airbyte into akorotkov/6422-oracle-source-secure-only

� Conflicts:
�	airbyte-integrations/connectors/source-oracle/src/main/java/io/airbyte/integrations/source/oracle/OracleSource.java
…6422-oracle-source-secure-only

� Conflicts:
�	airbyte-integrations/connectors/source-oracle/src/main/java/io/airbyte/integrations/source/oracle/OracleSource.java
�	docs/integrations/sources/oracle.md
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ andriikorotkov
❌ vmaltsev


vmaltsev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 8, 2021
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Oct 8, 2021

/test connector=connectors/source-oracle-strict-encrypt

🕑 connectors/source-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1321088405
✅ connectors/source-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1321088405
No Python unittests run

@andriikorotkov andriikorotkov linked an issue Oct 8, 2021 that may be closed by this pull request
6 tasks
@jrhizor jrhizor temporarily deployed to more-secrets October 8, 2021 16:21 Inactive
@andriikorotkov andriikorotkov marked this pull request as ready for review October 11, 2021 10:29
@andriikorotkov andriikorotkov temporarily deployed to more-secrets October 13, 2021 19:25 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets October 13, 2021 19:44 Inactive
Copy link
Contributor

@tuliren tuliren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also publish the connector before merging.

@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Oct 13, 2021

/test connector=connectors/source-oracle-strict-encrypt

🕑 connectors/source-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1339116892
✅ connectors/source-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1339116892
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets October 13, 2021 20:21 Inactive
@andriikorotkov andriikorotkov merged commit da627c5 into master Oct 13, 2021
@andriikorotkov andriikorotkov deleted the akorotkov/6422-oracle-source-secure-only branch October 13, 2021 20:35
@tuliren
Copy link
Contributor

tuliren commented Oct 13, 2021

@andriikorotkov, the test command does not publish the connector. You need to use the publish command for that.

@tuliren
Copy link
Contributor

tuliren commented Oct 13, 2021

@andriikorotkov, do you plan to publish it in a separate PR? If not, I will run the publish command here.

@andriikorotkov
Copy link
Contributor Author

@tuliren yes it is my mistake. I will post this connector now. thanks for noticing this

@andriikorotkov andriikorotkov restored the akorotkov/6422-oracle-source-secure-only branch October 13, 2021 21:43
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Oct 13, 2021

/publish connector=connectors/source-oracle-strict-encrypt

🕑 connectors/source-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1339381420
✅ connectors/source-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1339381420

@andriikorotkov andriikorotkov temporarily deployed to more-secrets October 13, 2021 21:45 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 13, 2021 21:46 Inactive
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* OracleSource add encryption

* add tests

* add tests

* remove debug option from Dockerfile

* add docs and fix unit tests

* remove System.out.println

* added oracle source secure only

* fix checkstyle | remove 'encryption' from required fields

* updated oracle source secure only

* updated oracle source secure only

* updated oracle source secure only code style

* updated oracle source secure only

* updated oracle secure only source

* fixed remarks

Co-authored-by: vmaltsev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a secure-only Oracle Source
6 participants