-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Create a secure-only Oracle Source #6898
🎉 Create a secure-only Oracle Source #6898
Conversation
# Conflicts: # docs/integrations/sources/oracle.md
…q/airbyte into akorotkov/6422-oracle-source-secure-only � Conflicts: � airbyte-integrations/connectors/source-oracle/src/main/java/io/airbyte/integrations/source/oracle/OracleSource.java
…6422-oracle-source-secure-only � Conflicts: � airbyte-integrations/connectors/source-oracle/src/main/java/io/airbyte/integrations/source/oracle/OracleSource.java � docs/integrations/sources/oracle.md
vmaltsev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
/test connector=connectors/source-oracle-strict-encrypt
|
...ain/java/io/airbyte/integrations/source/oracle_strict_encrypt/OracleStrictEncryptSource.java
Show resolved
Hide resolved
...e/integrations/source/oracle_strict_encrypt/OracleStrictEncryptJdbcSourceAcceptanceTest.java
Show resolved
Hide resolved
...e/integrations/source/oracle_strict_encrypt/OracleStrictEncryptJdbcSourceAcceptanceTest.java
Show resolved
Hide resolved
...e/integrations/source/oracle_strict_encrypt/OracleStrictEncryptJdbcSourceAcceptanceTest.java
Outdated
Show resolved
Hide resolved
...e/integrations/source/oracle_strict_encrypt/OracleStrictEncryptJdbcSourceAcceptanceTest.java
Outdated
Show resolved
Hide resolved
…6422-oracle-source-secure-only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also publish the connector before merging.
/test connector=connectors/source-oracle-strict-encrypt
|
@andriikorotkov, the |
@andriikorotkov, do you plan to publish it in a separate PR? If not, I will run the |
@tuliren yes it is my mistake. I will post this connector now. thanks for noticing this |
/publish connector=connectors/source-oracle-strict-encrypt
|
* OracleSource add encryption * add tests * add tests * remove debug option from Dockerfile * add docs and fix unit tests * remove System.out.println * added oracle source secure only * fix checkstyle | remove 'encryption' from required fields * updated oracle source secure only * updated oracle source secure only * updated oracle source secure only code style * updated oracle source secure only * updated oracle secure only source * fixed remarks Co-authored-by: vmaltsev <[email protected]>
What
Create a secure-only Oracle Source
How
Create a new secure-only Oracle Source with 2 options to Oracle source spec : Oracle Native Network Encryption and TLS(Server certificate verification)
![135823267-66b8a13a-0521-4674-81c0-e7346055b33b](https://user-images.githubusercontent.com/88329385/136590111-e0aeebc0-ac00-477f-8351-6fc9b4da0524.png)
![135823317-f23920a2-cd9f-4265-821c-05803a55129e](https://user-images.githubusercontent.com/88329385/136590123-bea71109-1d21-4386-af8f-f7ae5f89a362.png)
Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes