-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Google Workspace Admin: use SAT #6878
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
452b3cd
Add SAT
gaart 1b62e8f
Upd changelog
gaart 6846a58
Refactor
gaart 04fdd81
Upd acceptance-test-config: validate basic_read schema
gaart e16c433
Upd schemas: replace dynamic fields with object type
gaart 3cff46f
Updates after review
gaart 801a317
Upd schemas
gaart 14602bf
Upd schema
gaart 7c19379
Update docs/integrations/sources/google-workspace-admin-reports.md
gaart 478a600
Merge branch 'master' into gaart/6820-source-gwa-add-sat
gaart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Upd schemas: replace dynamic fields with object type
- Loading branch information
commit e16c433fd824e832ba0e688228ee9d92f1452943
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and below the events field has a dynamic structure, that is, this field is returned as an array of objects with different subfields and variable nesting. Is this okay to replace it with an
object
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could explain more about "dynamic" schema? Just asking because we are losing a lot of specificity in the data which makes it harder to consume. Are these essentially
oneOf
s? Was the existing schema incorrect?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sherifnada The
parameters
field has a list of objects with variable payload (different objects within the same array at the same point of time), in some cases there are deeply nested structures, and the inner items are different from each other, so theoneOf
is not applicable, theanyOf
possibly could workThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am just worried this will cause breaking changes to the schema. This is a pretty important stream (events are potentially the most important resource in this stream) so like described in UX handbook sections
Describe output schemas as completely and reliably as possible
andBe very cautious about breaking changes to output schemas
, it is probably worth attempting to describe the schema as completely as possible. Do you have any insight into how doable this is? @gaartThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sherifnada schema updated, nested fields added