Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement NoOpMigration for 0.30.0-alpha #6535

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Conversation

subodh1810
Copy link
Contributor

We tried to release version 0.30.0-alpha of Airbyte without any Migration for version 0.30.0-alpha but the deployment started failing. This is because we rely on Automatic migration to make the database version with the new version value here
But the fact that we didnt introduce any migration, the automatic migration failed saying no migration found for version 0.30.0-alpha.

Because of that the db version was not updated with the new incoming version and as a result the check AirbyteVersion.isCompatible(airbyteVersion, airbyteDatabaseVersion.get()) here failed and the server didnt start up.

In order to solve it we introduced a NoOpMigration and tested it locally and it worked

@subodh1810 subodh1810 self-assigned this Sep 29, 2021
@CLAassistant
Copy link

CLAassistant commented Sep 29, 2021

CLA assistant check
All committers have signed the CLA.

@@ -534,6 +534,7 @@
dockerRepository: airbyte/source-amazon-ads
dockerImageTag: 0.1.1
documentationUrl: https://docs.airbyte.io/integrations/sources/amazon-ads
sourceType: api
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was checking something else and came across that the sourceType is not listed for this so decided to add it anyway as part of this PR

@subodh1810 subodh1810 merged commit 13d13b2 into master Sep 29, 2021
@subodh1810 subodh1810 deleted the no-op-migration-v30 branch September 29, 2021 12:40
@tuliren
Copy link
Contributor

tuliren commented Sep 29, 2021

I think this will bite us in the future. Can we do something like this in ServerApp?

if (airbyteDatabaseVersion.isPresent() && isDatabaseVersionBehindAppVersion(airbyteVersion, airbyteDatabaseVersion.get())) {
   // run the migration
) else {
  jobPersistence.setVersion(airbyteVersion);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants