-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Jira: Add caching and more streams #6523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @cjwooo, I added some comments and request @vitaliizazmic to review your contribution too! thanks
airbyte-integrations/connectors/source-jira/source_jira/schemas/sprints.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @cjwooo
@cjwooo CI is not passing. Can you send your local tests?
https://github.com/airbytehq/airbyte/actions/runs/1301743551 |
I test using the same acceptance test files in the repo, but against our own playground Jira instance. I think I've fixed the test errors that were caused by the VCR caching. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @cjwooo
* Add caching for Jira source and add Boards stream * Fix draft version * Add sprints stream * Add vcr to setup.py * Formatting * Fix acceptance tests * Fix acceptance tests
What
Reduce the number of duplicate Jira API calls caused by nested streams and add a Boards and Sprints stream.
How
Use the same VCR caching strategy implemented by the Github Source, and integrate with an older version of the Jira Rest API that surfaces types of records that the latest V2 and V3 APIs do not support.
Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes