Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Destination MySQl - Added support for MySQL destination via TLS/SSL #6506

Merged
merged 5 commits into from
Sep 29, 2021
Merged

🎉 Destination MySQl - Added support for MySQL destination via TLS/SSL #6506

merged 5 commits into from
Sep 29, 2021

Conversation

andriikorotkov
Copy link
Contributor

What

Added support for MySQL destination via TLS/SSL

How

2021-09-28_10-28

2021-09-28_10-32

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@andriikorotkov
add support SSL for MySQL destination
b35a363
@andriikorotkov
Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…
d9763bd 
…6012-ssl-mysql-destination

� Conflicts:
�	airbyte-integrations/connectors/destination-mysql/src/main/java/io/airbyte/integrations/destination/mysql/MySQLDestination.java
@andriikorotkov
updated ssl tests and add documentation
fc1d7af
@CLAassistant
Copy link

CLAassistant commented Sep 28, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 28, 2021
@andriikorotkov andriikorotkov changed the title tada Destination MySQl - Added support for MySQL destination via TLS/SSL 🎉 Destination MySQl - Added support for MySQL destination via TLS/SSL Sep 28, 2021
@andriikorotkov andriikorotkov temporarily deployed to more-secrets September 28, 2021 13:33 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Sep 28, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-mysql

🕑 connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/1282890880
✅ connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/1282890880
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    11      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     117      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 10      0   100%
	 normalization/transform_catalog/stream_processor.py                 349    199    43%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         141     36    74%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1037    391    62%

@jrhizor jrhizor temporarily deployed to more-secrets September 28, 2021 13:59 Inactive
@andriikorotkov andriikorotkov linked an issue Sep 28, 2021 that may be closed by this pull request
Add support for MySQL destination via TLS/SSL #6012
Closed
5 tasks
alexandr-shegeda
alexandr-shegeda approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andriikorotkov andriikorotkov marked this pull request as ready for review September 29, 2021 06:48
sherifnada
sherifnada approved these changes Sep 29, 2021
View reviewed changes
...tination-mysql/src/main/java/io/airbyte/integrations/destination/mysql/MySQLDestination.java
@@ -73,12 +74,27 @@ protected JdbcDatabase getDatabase(JsonNode config) {

@Override
public JsonNode toJdbcConfig(JsonNode config) {
final List<String> additionalParameters = new ArrayList<>();

if (config.has("ssl") && config.get("ssl").asBoolean()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make SSL the default if it is not specified? This will make it easier to create a secure fork of the connector in #6423

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sherifnada, I changed default ssl value to true in spec

@andriikorotkov andriikorotkov temporarily deployed to more-secrets September 29, 2021 08:53 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Sep 29, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-mysql

🕑 connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/1286170489
✅ connectors/destination-mysql https://github.com/airbytehq/airbyte/actions/runs/1286170489

@jrhizor jrhizor temporarily deployed to more-secrets September 29, 2021 09:20 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets September 29, 2021 09:48 Inactive
@andriikorotkov andriikorotkov merged commit bbf098a into master Sep 29, 2021
@andriikorotkov andriikorotkov deleted the akorotkov/6012-ssl-mysql-destination branch September 29, 2021 12:23
This was referenced Sep 29, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@alexandr-shegeda alexandr-shegeda alexandr-shegeda approved these changes

@etsybaev etsybaev Awaiting requested review from etsybaev

@tuliren tuliren Awaiting requested review from tuliren

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for MySQL destination via TLS/SSL
5 participants
@andriikorotkov @CLAassistant @sherifnada @alexandr-shegeda @jrhizor