Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source GitHub: Add error handling for streams that are not applicable to some repos #6227

Merged
merged 2 commits into from
Sep 20, 2021
Merged

🐛 Source GitHub: Add error handling for streams that are not applicable to some repos #6227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f925de
Error handling for streams that are not applicable to some repos
cjwooo Sep 17, 2021
8974668
Handle users stream error
cjwooo Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion airbyte-integrations/connectors/source-github/source_github/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,23 @@ def read_records(self, stream_slice: Mapping[str, any] = None, **kwargs) -> Iter
elif e.response.status_code == requests.codes.NOT_FOUND and "/teams?" in error_msg:
# For private repositories `Teams` stream is not available and we get "404 Client Error: Not Found for
# url: https://api.github.com/orgs/sherifnada/teams?per_page=100" error.
error_msg = f"Syncing `Team` stream isn't available for repository `{stream_slice['repository']}`."
error_msg = f"Syncing `Team` stream isn't available for organization `{stream_slice['organization']}`."
elif e.response.status_code == requests.codes.GONE and "/projects?" in error_msg:
# Some repos don't have projects enabled and we we get "410 Client Error: Gone for
# url: https://api.github.com/repos/xyz/projects?per_page=100" error.
error_msg = f"Syncing `Projects` stream isn't available for repository `{stream_slice['repository']}`."
elif e.response.status_code == requests.codes.NOT_FOUND and "/orgs/" in error_msg:
# Some streams are not available for repositories owned by a user instead of an organization.
# Handle "404 Client Error: Not Found" errors
if isinstance(self, Repositories):
error_msg = f"Syncing `Repositories` stream isn't available for organization `{stream_slice['organization']}`."
elif isinstance(self, Users):
error_msg = f"Syncing `Users` stream isn't available for organization `{stream_slice['organization']}`."
elif isinstance(self, Organizations):
error_msg = f"Syncing `Organizations` stream isn't available for organization `{stream_slice['organization']}`."
else:
self.logger.error(f"Undefined error while reading records: {error_msg}")
raise e
elif e.response.status_code == requests.codes.CONFLICT:
error_msg = (
f"Syncing `{self.name}` stream isn't available for repository "
Expand Down