-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
secret coordinate helpers #6114
Conversation
todo:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was mainly looking at test cases, the main one I would suggest adding is a nested oneof (inside an object)
another thing is that it would have been super helpful to have javadocs on the classes and public methods to help the reader understand what's going on.
@sherifnada I fixed the I also cleaned up the I'm going to add a ton of javadocs in the morning and slightly improve on some of the naming and then merge if there aren't any objections. |
resolves #6099